Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Nominate mbevc1 as an approver #767

Merged
merged 7 commits into from
Jun 1, 2021

Conversation

mbevc1
Copy link
Collaborator

@mbevc1 mbevc1 commented May 28, 2021

Related to: #612

We use ArgoCD and notifications chart in K8s clusters and happy to contribute back.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have updated the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

Signed-off-by: Marko Bevc <marko@scalefactory.com>
@mkilchhofer mkilchhofer requested review from alexec and alexmt May 29, 2021 08:42
@alexec alexec merged commit 818cf41 into argoproj:master Jun 1, 2021
terrych0u pushed a commit to terrych0u/argo-helm that referenced this pull request Sep 7, 2021
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants